[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/23] qcow2: Remove bogus unlock of s->lock
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 04/23] qcow2: Remove bogus unlock of s->lock |
Date: |
Thu, 28 Mar 2013 17:40:18 +0100 |
From: Kevin Wolf <address@hidden>
The unlock wakes up the next coroutine, but the currently running
coroutine will lock it again before it yields, so this doesn't make a
lot of sense.
Signed-off-by: Kevin Wolf <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/qcow2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 8ea696a..3f7edf5 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -869,9 +869,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState
*bs,
QLIST_REMOVE(l2meta, next_in_flight);
}
- qemu_co_mutex_unlock(&s->lock);
qemu_co_queue_restart_all(&l2meta->dependent_requests);
- qemu_co_mutex_lock(&s->lock);
g_free(l2meta);
l2meta = NULL;
--
1.8.1.4
- [Qemu-devel] [PULL 00/23] Block patches, Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 02/23] qemu-iotests: More concurrent allocation scenarios, Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 01/23] vl.c: call bdrv_init_with_whitelist() before cmdline parsing, Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 05/23] qcow2: Handle dependencies earlier, Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 03/23] qcow2: Fix "total clusters" number in bdrv_check, Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 04/23] qcow2: Remove bogus unlock of s->lock,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 06/23] qcow2: Improve check for overlapping allocations, Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 08/23] qcow2: Decouple cluster allocation from cluster reuse code, Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 07/23] qcow2: Change handle_dependency to byte granularity, Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 09/23] qcow2: Factor out handle_alloc(), Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 11/23] qcow2: handle_alloc(): Get rid of keep_clusters parameter, Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 10/23] qcow2: handle_alloc(): Get rid of nb_clusters parameter, Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 12/23] qcow2: Finalise interface of handle_alloc(), Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 13/23] qcow2: Clean up handle_alloc(), Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 14/23] qcow2: Factor out handle_copied(), Stefan Hajnoczi, 2013/03/28
- [Qemu-devel] [PATCH 15/23] qcow2: handle_copied(): Get rid of nb_clusters parameter, Stefan Hajnoczi, 2013/03/28