[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V14 5/5] VMXNET3 device implementation
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH V14 5/5] VMXNET3 device implementation |
Date: |
Wed, 27 Mar 2013 16:46:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 27/03/2013 15:49, Alexander Graf ha scritto:
>> > +#if defined(HOST_WORDS_BIGENDIAN)
>> > +#define const_cpu_to_le64(x) bswap_64(x)
>> > +#define __BIG_ENDIAN_BITFIELD
> Ah, sorry, I replied to the wrong version.
>
> ARE YOU KIDDING ME? BIG ENDIAN BITFIELD? BITFIELDS ARE _IMPLEMENTATION
> SPECIFIC_!
>
> Can we please revert this whole patch set and send the authors back to school?
Can we please maintain a decent tone?
First, this file comes from Linux. __BIG_ENDIAN_BITFIELD is a Linux
#define. No doubt it is wrong to define it based on
HOST_WORDS_BIGENDIAN, it is better to use a configure check. But it's
not the reason why PPC compilation fails.
Second, you haven't said _how_ it breaks PPC compilation. Just
cut-and-paste from the compiler is enough. Ok, I can guess it but not
always.
Third, there is no need to revert the patch set. The const_cpu_to_le64
should simply be removed, since little-endian conversion is already done
in vmw_shmem_ld32.
Paolo
- [Qemu-devel] [PATCH V14 0/5] VMXNET3 paravirtual NIC device implementation, Dmitry Fleytman, 2013/03/09
- [Qemu-devel] [PATCH V14 1/5] Checksum-related utility functions, Dmitry Fleytman, 2013/03/09
- [Qemu-devel] [PATCH V14 2/5] net: iovec checksum calculator, Dmitry Fleytman, 2013/03/09
- [Qemu-devel] [PATCH V14 3/5] Common definitions for VMWARE devices, Dmitry Fleytman, 2013/03/09
- [Qemu-devel] [PATCH V14 4/5] Packet abstraction for VMWARE network devices, Dmitry Fleytman, 2013/03/09
- [Qemu-devel] [PATCH V14 5/5] VMXNET3 device implementation, Dmitry Fleytman, 2013/03/09
Re: [Qemu-devel] [PATCH V14 0/5] VMXNET3 paravirtual NIC device implementation, Stefan Hajnoczi, 2013/03/12