Re: [Qemu-devel] [PATCH 07/11] qemu-char: Move incrementing of avail_connections to qdev-properties-system

[Paolo Bonzini]

Il 27/03/2013 15:09, Hans de Goede ha scritto:
> Hi,
> 
> On 03/26/2013 02:50 PM, Paolo Bonzini wrote:
> 
> <snip>
> 
>>> 1) For most problematic devices, the proper fix would be to make them
>>> use a chardev qdev property for there chardev usage, and then this
>>> would be automatically fixed, agreed?
>>
>> At least on x86, all devices already use a chardev qdev property.
> 
> Yes on x86 maybe, but a lot of the other serial-port emulations are
> still using serial_hds directly, making proper avail_connections tracking
> a pain.

serial_hds is still passed to most devices via a chardev qdev property.
 See for example sparc/leon3.c, which uses grlib_apbuart_create and that
function sets the chardev.

Luckily there are very few UART implementations, most boards use the
8250/16550, hence this is even true of boards that are generally not
qdev-ified (like OMAP).  There are exceptions, like mcf_uart.c and
bt-hci-csr.c.

Paolo

> Anyways I've audited all frontends now, fixing things where necessary,
> and where possible in a generic way.
> 
> I'll send a patch for this right after this mail.
> 
> Regards,
> 
> Hans