[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] monitor: do not rely on O_NONBLOCK for pass
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors |
Date: |
Wed, 27 Mar 2013 14:39:43 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 27, 2013 at 02:06:36PM +0100, Juan Quintela wrote:
> Stefan Hajnoczi <address@hidden> wrote:
> > On Wed, Mar 27, 2013 at 04:37:52PM +0800, liu ping fan wrote:
> >> On Wed, Mar 27, 2013 at 12:07 AM, Stefan Hajnoczi <address@hidden> wrote:
> >> > There are several places where QEMU accidentally relies on the
> >> > O_NONBLOCK state
> >> > of passed file descriptors. Exposing O_NONBLOCK state makes it
> >> > part of the QMP
> >>
> >> If in future, we push more backend on their dedicated thread, will the
> >> related fd be block?
> >
> > This series is not related to threading in QEMU. The convention it
> > establishes is that passed fds are blocking. If QEMU wants to use
> ^^^^^^^^
> You mean here non-blocking
>
> > nonblocking it must call qemu_set_block(fd). This works whether it is
> ^^^^^^^^^^^^^^^^^^
> or here qemu_set_nonblock(fd)
>
> no?
>
> I guess the second one O:-)
Blocking by default, call qemu_set_nonblock(fd) if you need
non-blocking.
:)
Sorry for the mistake.
Stefan
- Re: [Qemu-devel] [PATCH 1/4] net: ensure "socket" backend uses non-blocking fds, (continued)