[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/12] vm-snapshot-save: add force parameter
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 11/12] vm-snapshot-save: add force parameter |
Date: |
Tue, 26 Mar 2013 16:04:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/22/2013 07:16 AM, Pavel Hrdina wrote:
> HMP command "savevm" now takes extra optional force parameter to specify
> whether
> replace existing snapshot or not.
>
> QMP command "vm-snapshot-save" has also extra optional force parameter and
> name parameter isn't optional anymore.
Again, my question from 7/12 - why not rebase this series to implement
QMP correctly from the getgo, and have this patch be JUST an HMP
addition to expose the new QMP capability?
>
> Signed-off-by: Pavel Hrdina <address@hidden>
> ---
> hmp-commands.hx | 15 ++++++++-------
> hmp.c | 3 ++-
> qapi-schema.json | 7 +++++--
> qmp-commands.hx | 16 ++++++++++------
> savevm.c | 25 ++++++++++++++++---------
> 5 files changed, 41 insertions(+), 25 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 3c1cb05..bfe0645 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -307,18 +307,19 @@ ETEXI
>
> {
> .name = "savevm",
> - .args_type = "name:s?",
> - .params = "[tag|id]",
> - .help = "save a VM snapshot. If no tag or id are provided, a
> new snapshot is created",
> + .args_type = "force:-f,name:s?",
> + .params = "[-f] [tag|id]",
> + .help = "save a VM snapshot. To replace existing snapshot use
> force flag.",
Not an error message, so I'm not duplicating myself :)
Prevailing convention seems to be omitting trailing '.' in .help messages.
> .mhandler.cmd = hmp_vm_snapshot_save,
> },
>
> STEXI
> address@hidden savevm address@hidden|@var{id}]
> address@hidden savevm address@hidden @var{tag}|@var{id}
> @findex savevm
> -Create a snapshot of the whole virtual machine. If @var{tag} is
> -provided, it is used as human readable identifier. If there is already
> -a snapshot with the same @var{tag} or @var{id}, it is replaced. More info at
> +Create a snapshot of the whole virtual machine. Parameter "name" is optional.
> +If @var{tag} is provided, it is used as human readable identifier. If there
> is
> +already a snapshot with the same @var{tag} or @var{id}, @var{-f} flag needs
> to
> +be specified. More info at @ref{vm_snapshots}.
> @ref{vm_snapshots}.
@ref{vm_snapshots} now appears twice in the output.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 06/12] savevm: add error parameter to qemu_savevm_state(), (continued)
- [Qemu-devel] [PATCH v2 08/12] qemu-img: introduce qemu_img_handle_error, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 10/12] savevm: update return value from qemu_savevm_state, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 09/12] block: update return value from bdrv_snapshot_create, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 12/12] savevm: icrease the IO_BUF_SIZE to improve the speed of savevm, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 11/12] vm-snapshot-save: add force parameter, Pavel Hrdina, 2013/03/22
- Re: [Qemu-devel] [PATCH v2 11/12] vm-snapshot-save: add force parameter,
Eric Blake <=