[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv4 8/9] migration: do not search dirty pages in b
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCHv4 8/9] migration: do not search dirty pages in bulk stage |
Date: |
Mon, 25 Mar 2013 12:05:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 03/22/2013 02:46 PM, Peter Lieven wrote:
> avoid searching for dirty pages just increment the
> page offset. all pages are dirty anyway.
>
> Signed-off-by: Peter Lieven <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> arch_init.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index c34a4af..b2b932a 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -338,7 +338,13 @@ ram_addr_t
> migration_bitmap_find_and_reset_dirty(MemoryRegion *mr,
> unsigned long nr = base + (start >> TARGET_PAGE_BITS);
> unsigned long size = base + (int128_get64(mr->size) >> TARGET_PAGE_BITS);
>
> - unsigned long next = find_next_bit(migration_bitmap, size, nr);
> + unsigned long next;
> +
> + if (ram_bulk_stage && nr > base) {
> + next = nr + 1;
> + } else {
> + next = find_next_bit(migration_bitmap, size, nr);
> + }
>
> if (next < size) {
> clear_bit(next, migration_bitmap);
>
Reviewed-by: Orit Wasserman <address@hidden>
- [Qemu-devel] [PATCHv4 0/9] buffer_is_zero / migration optimizations, Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 5/9] migration: search for zero instead of dup pages, Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 3/9] buffer_is_zero: use vector optimizations if possible, Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 8/9] migration: do not search dirty pages in bulk stage, Peter Lieven, 2013/03/22
- Re: [Qemu-devel] [PATCHv4 8/9] migration: do not search dirty pages in bulk stage,
Orit Wasserman <=
- [Qemu-devel] [PATCHv4 1/9] move vector definitions to qemu-common.h, Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 9/9] migration: use XBZRLE only after bulk stage, Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 4/9] bitops: use vector algorithm to optimize find_next_bit(), Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 6/9] migration: add an indicator for bulk state of ram migration, Peter Lieven, 2013/03/22
- [Qemu-devel] [PATCHv4 2/9] cutils: add a function to find non-zero content in a buffer, Peter Lieven, 2013/03/22