Re: [Qemu-devel] [PATCH 03/14] block: Add options QDict to bdrv_file_open() prototypes

[Peter Maydell]

On 22 March 2013 17:41, Kevin Wolf <address@hidden> wrote:
> The new parameter is unused yet.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

> --- a/include/block/block_int.h
> +++ b/include/block/block_int.h
> @@ -83,7 +83,8 @@ struct BlockDriver {
>      void (*bdrv_reopen_abort)(BDRVReopenState *reopen_state);
>
>      int (*bdrv_open)(BlockDriverState *bs, QDict *options, int flags);
> -    int (*bdrv_file_open)(BlockDriverState *bs, const char *filename, int 
> flags);
> +    int (*bdrv_file_open)(BlockDriverState *bs, const char *filename,
> +                          QDict *options, int flags);

This seems to break compilation:

  CC    block/rbd.o
block/rbd.c:940:5: error: initialization from incompatible pointer
type [-Werror]
block/rbd.c:940:5: error: (near initialization for
‘bdrv_rbd.bdrv_file_open’) [-Werror]
cc1: all warnings being treated as errors

thanks
-- PMM