[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/14] nbd: Accept -drive options for the networ
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 08/14] nbd: Accept -drive options for the network connection |
Date: |
Fri, 22 Mar 2013 23:50:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 22/03/2013 18:41, Kevin Wolf ha scritto:
> +
> + if (qdict_haskey(options, "path")) {
> + s->is_unix = true;
> + } else if (qdict_haskey(options, "host")) {
> + s->is_unix = false;
> + } else {
> + return -EINVAL;
> }
> - return err;
> +
> + s->socket_opts = qemu_opts_create_nofail(&socket_optslist);
> +
> + qemu_opts_absorb_qdict(s->socket_opts, options, &local_err);
Similarly, this should create a SocketAddress and then just use
socket_connect.
Paolo
- [Qemu-devel] [PULL 00/14] Block patches, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 01/14] Revert "block: complete all IOs before .bdrv_truncate", Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 02/14] block: complete all IOs before resizing a device, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 04/14] block: Pass bdrv_file_open() options to block drivers, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 07/14] nbd: Remove unused functions, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 08/14] nbd: Accept -drive options for the network connection, Kevin Wolf, 2013/03/22
- Re: [Qemu-devel] [PATCH 08/14] nbd: Accept -drive options for the network connection,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 05/14] qemu-socket: Make socket_optslist public, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 10/14] block: Rename variable to avoid shadowing, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 11/14] block: Make find_image_format safe with NULL filename, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 03/14] block: Add options QDict to bdrv_file_open() prototypes, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 14/14] nbd: Check against invalid option combinations, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 06/14] nbd: Keep hostname and port separate, Kevin Wolf, 2013/03/22
- [Qemu-devel] [PATCH 09/14] block: Introduce .bdrv_parse_filename callback, Kevin Wolf, 2013/03/22