[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 9/9] coalesce adjacent iovecs
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v3 9/9] coalesce adjacent iovecs |
Date: |
Thu, 21 Mar 2013 18:44:14 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> wrote:
> On Thu, Mar 21, 2013 at 06:27:42PM +0200, Orit Wasserman wrote:
>> On 03/21/2013 06:16 PM, Michael S. Tsirkin wrote:
>> > On Thu, Mar 21, 2013 at 06:05:40PM +0200, Orit Wasserman wrote:
>> >> This way we send one big buffer instead of many small ones
>> >>
>> >> Signed-off-by: Orit Wasserman <address@hidden>
>> >
>> > Why does this happen BTW?
>>
>> It happens in the last phase when we send the device state that
>> consists of a lot
>> bytes and int field that are written using qemu_put_byte/be16/...
>>
>
> Confused I thought device_state does not use _nocopy?
> My idea of using vmsplice relies exactly on this:
> we can not splice device state ...
As it is today, I am not sure that we can use vmsplice() because we
are sending:
<header>
<page>
<header>
<page>
<header>
<page>
We can optimize at some pount to write a bigger/different header and
sent a bunch of pages together, but just now we don't have that code.
Later, Juan.
- Re: [Qemu-devel] [PATCH v3 6/9] More optimized qemu_put_be64/32/16, (continued)
Re: [Qemu-devel] [PATCH v3 9/9] coalesce adjacent iovecs, Juan Quintela, 2013/03/21
[Qemu-devel] [PATCH v3 8/9] Use qemu_put_buffer_no_copy for guest memory pages, Orit Wasserman, 2013/03/21
Re: [Qemu-devel] [PATCH v3 0/9] Migration: Remove copying of guest ram pages, Paolo Bonzini, 2013/03/21