[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/10] virtio-scsi refactoring.
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v4 00/10] virtio-scsi refactoring. |
Date: |
Wed, 20 Mar 2013 16:54:11 +0100 |
On Wed, 20 Mar 2013 15:07:33 +0100
address@hidden wrote:
> From: KONRAD Frederic <address@hidden>
>
> This is the next part of virtio-refactoring.
>
> Basically it creates virtio-scsi device which extends virtio-device.
> Then a virtio-scsi can be connected on a virtio-bus.
> virtio-scsi-pci, virtio-scsi-s390x, virtio-scsi-ccw are created too, they
> extend
> respectively virtio-pci, virtio-s390-device, virtio-ccw-device and have a
> virtio-scsi.
>
> You can checkout my branch here:
>
> git://project.greensocs.com/qemu-virtio.git virtio-scsi-v4
I have not looked at the code yet, but with this tree I can create
virtio-scsi-ccw and virtio-scsi-s390 devices that look sane at first
glance. On virtio-ccw, the device also detaches without creating a
hiccup in qemu.
>
> Note that it is nearly the same series as virtio-blk refactoring. Though the
> 2nd
> and the 3rd steps are a virtio-scsi specific.
>
> I made basic tests (with linux guests) on:
> * qemu-system-i386
>
> Changes v3 -> v4:
> * Added CCW device.
> * Fixed the configuration issue.
>
> Thanks,
>
> Fred
>
> KONRAD Frederic (10):
> virtio-scsi: don't use pointer for configuration.
> virtio-scsi: allocate cmd_vqs array separately.
> virtio-scsi: moving host_features from properties to transport
> properties.
> virtio-scsi: add the virtio-scsi device.
> virtio-scsi-pci: switch to new API.
> virtio-scsi-s390: switch to the new API.
> virtio-scsi-ccw: switch to new API
> virtio-scsi: cleanup: use QOM casts.
> virtio-scsi: cleanup: init and exit functions.
> virtio-scsi: cleanup: remove qdev field.
>
> hw/s390x/s390-virtio-bus.c | 30 ++++++++---
> hw/s390x/s390-virtio-bus.h | 11 +++-
> hw/s390x/virtio-ccw.c | 32 +++++++-----
> hw/s390x/virtio-ccw.h | 12 ++++-
> hw/virtio-pci.c | 119 ++++++++++++++++++++++---------------------
> hw/virtio-pci.h | 15 +++++-
> hw/virtio-scsi.c | 122
> ++++++++++++++++++++++++++++++---------------
> hw/virtio-scsi.h | 21 ++++----
> 8 files changed, 230 insertions(+), 132 deletions(-)
>
- [Qemu-devel] [PATCH v4 01/10] virtio-scsi: don't use pointer for configuration., (continued)
- [Qemu-devel] [PATCH v4 01/10] virtio-scsi: don't use pointer for configuration., fred . konrad, 2013/03/20
- [Qemu-devel] [PATCH v4 02/10] virtio-scsi: allocate cmd_vqs array separately., fred . konrad, 2013/03/20
- [Qemu-devel] [PATCH v4 03/10] virtio-scsi: moving host_features from properties to transport properties., fred . konrad, 2013/03/20
- [Qemu-devel] [PATCH v4 06/10] virtio-scsi-s390: switch to the new API., fred . konrad, 2013/03/20
- [Qemu-devel] [PATCH v4 05/10] virtio-scsi-pci: switch to new API., fred . konrad, 2013/03/20
- [Qemu-devel] [PATCH v4 07/10] virtio-scsi-ccw: switch to new API, fred . konrad, 2013/03/20
- [Qemu-devel] [PATCH v4 04/10] virtio-scsi: add the virtio-scsi device., fred . konrad, 2013/03/20
- [Qemu-devel] [PATCH v4 09/10] virtio-scsi: cleanup: init and exit functions., fred . konrad, 2013/03/20
- [Qemu-devel] [PATCH v4 08/10] virtio-scsi: cleanup: use QOM casts., fred . konrad, 2013/03/20
- [Qemu-devel] [PATCH v4 10/10] virtio-scsi: cleanup: remove qdev field., fred . konrad, 2013/03/20
- Re: [Qemu-devel] [PATCH v4 00/10] virtio-scsi refactoring.,
Cornelia Huck <=