|
From: | Peter Lieven |
Subject: | Re: [Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer |
Date: | Tue, 19 Mar 2013 17:18:01 +0100 |
Am 19.03.2013 um 16:54 schrieb Eric Blake <address@hidden>: > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven <address@hidden> >> --- >> include/qemu-common.h | 2 ++ >> util/cutils.c | 40 ++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 42 insertions(+) >> > >> >> +#define BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR 8 > > Good. > >> + assert(len % (BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR >> + * sizeof(VECTYPE)) == 0); > > Good use of it. A question I had is if these asserts make the code slower? In case of all the 4k pages in RAM migration this could be significant. Peter
[Prev in Thread] | Current Thread | [Next in Thread] |