[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load |
Date: |
Tue, 19 Mar 2013 10:28:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.3 |
On 03/19/13 10:15, Alon Levy wrote:
>>> + vmstate_register(NULL, -1, &spice_chr_vmstate, s);
>>> +
>>
>> That is a showstopper. If there are two of these there is no
>> reliable
>> way to figure which is which.
>
> But they will both get a different state pointer s.
I mean in the migration data stream.
> It is being migrated in virtio-serial-bus (port->guest_connected)
> but we need to pass that on to spice-server, which there is no hook
> for in the chardev layer, I could add one. I would need to query the
> backend, in this case virtio-serial-bus, something like this:
That is better IMHO.
cheers,
Gerd
- [Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 1/8] virtio-console: Also throttle when less was written then requested, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 4/8] spice-qemu-char: Add watch support, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 2/8] virtio-console: Remove any pending watches on close, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 3/8] spice-qemu-char: Remove #ifdef-ed code for old spice-server compat, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 6/8] spice-qemu-char: Move spice_chr_close down, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 5/8] spice-qemu-char: Remove intermediate buffer, Hans de Goede, 2013/03/14
- Re: [Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2, Amit Shah, 2013/03/18