[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] dataplane: fix hang introduced by AioContext tr
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] dataplane: fix hang introduced by AioContext transition |
Date: |
Thu, 14 Mar 2013 10:57:25 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 13, 2013 at 03:14:15PM +0100, Paolo Bonzini wrote:
> The bug is that the EventNotifiers do have a NULL io_flush callback.
> Because _none_ of the callbacks on the dataplane AioContext have such a
> callback, aio_poll will simply do nothing. Fixed by adding the callbacks:
> the ioeventfd will always be polled (this can change in the future to
> pause/resume the processing during live snapshots or similar operations);
> the ioqueue will be polled if there are outstanding requests.
>
> I must admit I have screwed up my testing somehow, because commit
> 2c20e71 does not work even if cherry-picked on top of 1.4.0, and this
> patch fixes it there as well.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/dataplane/virtio-blk.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
Thanks, tested and applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan