[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/20] chardev: switch file init to qapi
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 06/20] chardev: switch file init to qapi |
Date: |
Thu, 14 Mar 2013 09:57:27 +0100 |
This patch switches over the 'file' chardev initialization
to the new qapi code path.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
qemu-char.c | 43 +++++++++++++++----------------------------
1 file changed, 15 insertions(+), 28 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 1692aa8..4b9caca 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -841,18 +841,6 @@ static CharDriverState *qemu_chr_open_fd(int fd_in, int
fd_out)
return chr;
}
-static CharDriverState *qemu_chr_open_file_out(QemuOpts *opts)
-{
- int fd_out;
-
- TFR(fd_out = qemu_open(qemu_opt_get(opts, "path"),
- O_WRONLY | O_TRUNC | O_CREAT | O_BINARY, 0666));
- if (fd_out < 0) {
- return NULL;
- }
- return qemu_chr_open_fd(-1, fd_out);
-}
-
static CharDriverState *qemu_chr_open_pipe(QemuOpts *opts)
{
int fd_in, fd_out;
@@ -1989,20 +1977,6 @@ static CharDriverState *qemu_chr_open_win_con(QemuOpts
*opts)
return qemu_chr_open_win_file(GetStdHandle(STD_OUTPUT_HANDLE));
}
-static CharDriverState *qemu_chr_open_win_file_out(QemuOpts *opts)
-{
- const char *file_out = qemu_opt_get(opts, "path");
- HANDLE fd_out;
-
- fd_out = CreateFile(file_out, GENERIC_WRITE, FILE_SHARE_READ, NULL,
- OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
- if (fd_out == INVALID_HANDLE_VALUE) {
- return NULL;
- }
-
- return qemu_chr_open_win_file(fd_out);
-}
-
static int win_stdio_write(CharDriverState *chr, const uint8_t *buf, int len)
{
HANDLE hStdOut = GetStdHandle(STD_OUTPUT_HANDLE);
@@ -3202,6 +3176,19 @@ static CharDriverState *qemu_chr_open_pp(QemuOpts *opts)
#endif
+static void qemu_chr_parse_file_out(QemuOpts *opts, ChardevBackend *backend,
+ Error **errp)
+{
+ const char *path = qemu_opt_get(opts, "path");
+
+ if (path == NULL) {
+ error_setg(errp, "chardev: file: no filename given");
+ return;
+ }
+ backend->file = g_new0(ChardevFile, 1);
+ backend->file->out = g_strdup(path);
+}
+
typedef struct CharDriver {
const char *name;
/* old, pre qapi */
@@ -3770,14 +3757,14 @@ static void register_types(void)
register_char_driver("socket", qemu_chr_open_socket);
register_char_driver("udp", qemu_chr_open_udp);
register_char_driver("memory", qemu_chr_open_ringbuf);
+ register_char_driver_qapi("file", CHARDEV_BACKEND_KIND_FILE,
+ qemu_chr_parse_file_out);
#ifdef _WIN32
- register_char_driver("file", qemu_chr_open_win_file_out);
register_char_driver("pipe", qemu_chr_open_win_pipe);
register_char_driver("console", qemu_chr_open_win_con);
register_char_driver("serial", qemu_chr_open_win);
register_char_driver("stdio", qemu_chr_open_win_stdio);
#else
- register_char_driver("file", qemu_chr_open_file_out);
register_char_driver("pipe", qemu_chr_open_pipe);
register_char_driver("stdio", qemu_chr_open_stdio);
#endif
--
1.7.9.7
- [Qemu-devel] [PATCH 02/20] chardev: add mux chardev support to qapi, (continued)
- [Qemu-devel] [PATCH 02/20] chardev: add mux chardev support to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 04/20] chardev: add msmouse support to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 11/20] chardev: add console support to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 08/20] chardev: switch serial/tty init to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 19/20] spice-qemu-char: Fix name parameter issues after qapi-ifying, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 09/20] chardev: switch parallel init to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 03/20] chardev: switch null init to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 15/20] chardev: add memory (ringbuf) support to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 12/20] chardev: add pipe support to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 10/20] chardev: switch pty init to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 06/20] chardev: switch file init to qapi,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 14/20] chardev: add vc support to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 07/20] chardev: add stdio support to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 17/20] Revert "hmp: Disable chardev-add and chardev-remove", Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 05/20] chardev: add braille support to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 18/20] qemu-char.c: fix waiting for telnet connection message, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 16/20] chardev: add udp support to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 13/20] chardev: add spice support to qapi, Gerd Hoffmann, 2013/03/14
- [Qemu-devel] [PATCH 20/20] spice-qemu-char: Remove dead debugging code, Gerd Hoffmann, 2013/03/14
- Re: [Qemu-devel] [PULL v4 00/20] chardev: qapi conversion continued, Eric Blake, 2013/03/14