[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 WIP 2/2] vhost-scsi: new device supporting th
From: |
Asias He |
Subject: |
Re: [Qemu-devel] [PATCH V2 WIP 2/2] vhost-scsi: new device supporting the tcm_vhost Linux kernel module |
Date: |
Wed, 13 Mar 2013 10:49:18 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 12, 2013 at 09:20:24AM +0100, Stefan Hajnoczi wrote:
> On Tue, Mar 12, 2013 at 02:29:42PM +0800, Asias He wrote:
> > diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> > index 39c1966..4a97ca1 100644
> > --- a/hw/virtio-pci.c
> > +++ b/hw/virtio-pci.c
>
> These changes break the build for non-Linux hosts. Please introduce a
> CONFIG_VHOST_SCSI and #ifdef appropriate sections in hw/virtio-pci.c.
>
> CONFIG_VIRTFS does the same thing.
okay.
> > +static Property vhost_scsi_properties[] = {
> > + DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags,
> > VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
>
> This flag makes QEMU's virtqueue handling use ioeventfd. Since the
> vhost-scsi.c takes over the guest/host notifiers, we never do QEMU
> virtqueue processing and the "ioeventfd" flag has no real meaning. You
> can drop it.
okay.
Thanks, Stefan!
--
Asias