[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] find_next_bit optimizations
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC] find_next_bit optimizations |
Date: |
Mon, 11 Mar 2013 15:37:40 +0000 |
On 11 March 2013 15:24, Peter Lieven <address@hidden> wrote:
> + unsigned long d0,d1,d2,d3;
These commas should have spaces after them. Also, since
the variables are only used inside the scope of your
newly added while loop:
> - while (size & ~(BITS_PER_LONG-1)) {
> + while (size >= 4*BITS_PER_LONG) {
it would be better to declare them here.
> + d0 = *p;
> + d1 = *(p+1);
> + d2 = *(p+2);
> + d3 = *(p+3);
> + if (d0 || d1 || d2 || d3) {
> + break;
> + }
> + p+=4;
> + result += 4*BITS_PER_LONG;
> + size -= 4*BITS_PER_LONG;
> + }
> + while (size >= BITS_PER_LONG) {
> if ((tmp = *(p++))) {
> goto found_middle;
> }
thanks
-- PMM
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, (continued)
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Paolo Bonzini, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Lieven, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Paolo Bonzini, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Lieven, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Paolo Bonzini, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, ronnie sahlberg, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Paolo Bonzini, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Lieven, 2013/03/11
- [Qemu-devel] [PATCH] bitops: unroll while loop in find_next_bit()., Peter Lieven, 2013/03/12
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Maydell, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations,
Peter Maydell <=
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Lieven, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Paolo Bonzini, 2013/03/11
- Re: [Qemu-devel] [RFC] find_next_bit optimizations, Peter Lieven, 2013/03/11
Re: [Qemu-devel] [RFC] find_next_bit optimizations, Stefan Hajnoczi, 2013/03/12