[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg: Don't make exitreq flag a local temporary
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] tcg: Don't make exitreq flag a local temporary |
Date: |
Sat, 9 Mar 2013 19:01:09 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 05, 2013 at 08:54:41AM -0800, Richard Henderson wrote:
> The value is not actually live across basic blocks, so there's no
> need for the local property. This eliminates storing the temporary
> to its home location at the branch.
>
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> include/exec/gen-icount.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h
> index 4e3b17b..4fc7b29 100644
> --- a/include/exec/gen-icount.h
> +++ b/include/exec/gen-icount.h
> @@ -15,7 +15,7 @@ static inline void gen_tb_start(void)
> TCGv_i32 flag;
>
> exitreq_label = gen_new_label();
> - flag = tcg_temp_local_new_i32();
> + flag = tcg_temp_new_i32();
> tcg_gen_ld_i32(flag, cpu_env,
> offsetof(CPUState, tcg_exit_req) - ENV_OFFSET);
> tcg_gen_brcondi_i32(TCG_COND_NE, flag, 0, exitreq_label);
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net