[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V8 10/20] qmp: add interface query-snapshots
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V8 10/20] qmp: add interface query-snapshots |
Date: |
Fri, 08 Mar 2013 16:30:54 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
On 03/06/2013 11:07 PM, Wenchao Xia wrote:
> This interface now return valid internal snapshots for whole vm.
s/now return/returns/
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block/qapi.c | 22 +++++++++++++++++++++
> qapi-schema.json | 14 +++++++++++++
> qmp-commands.hx | 55
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 91 insertions(+), 0 deletions(-)
>
> +
> +SnapshotInfoList *qmp_query_snapshots(Error **errp)
> +{
> + BlockDriverState *bs;
> + SnapshotInfoList *list = NULL;
> + int ret;
> +
> + /* internal snapshot for whole vm */
> + bs = bdrv_snapshots();
> + if (!bs) {
> + error_setg(errp, "No available block device supports snapshots\n");
> + return NULL;
> + }
> +
list is NULL here,
> + ret = bdrv_query_snapshot_info_list(bs, &list, true, errp);
> + if (ret < 0) {
> + qapi_free_SnapshotInfoList(list);
and you documented that bdrv_query_snapshot_info_list leaves list
untouched on error, so why do you have to clean it up?
> + list = NULL;
> + }
> + return list;
In fact, you could write this as:
bdrv_query_snapshot_info_list(bs, &list, true, errp);
return list;
without needing 'ret'.
> ##
> +# @query-snapshots:
> +#
> +# Get a list of internal snapshots for whole virtual machine, only valid
s/for/for the/; s/machine, only/machine. Only/
> +# internal snapshot will be returned, inconsistent ones will be ignored
s/snapshot/snapshots/
> SQMP
> +query-snapshots
> +-----------
Common practice is to make the divider line match the line length of the
line above (you were short by '----')
> +
> +Show the internal consistent snapshot information
> +
> +Each snapshot is represented by a json-object. The returned value
> +is a json-array of all snapshots
> +
> +Each json-object contain the following:
> +
> +- "id": unique snapshot id (json-string)
> +- "name": internal snapshot name (json-string)
> +- "vm-state-size": size of the VM state in bytes (json-int)
> +- "date-sec": UTC date of the snapshot in seconds (json-int)
> +- "date-nsec": fractional part in nano seconds to be used with
s/nano seconds/nanoseconds/
> + date-sec(json-int)
> +- "vm-clock-sec": VM clock relative to boot in seconds (json-int)
> +- "vm-clock-nsec": fractional part in nano seconds to be used with
and again
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V8 06/20] block: move collect_snapshots() and collect_image_info() to block/qapi.c, (continued)
- [Qemu-devel] [PATCH V8 06/20] block: move collect_snapshots() and collect_image_info() to block/qapi.c, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 08/20] block: add filter for vm snapshot in bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 09/20] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 10/20] qmp: add interface query-snapshots, Wenchao Xia, 2013/03/07
- Re: [Qemu-devel] [PATCH V8 10/20] qmp: add interface query-snapshots,
Eric Blake <=
- [Qemu-devel] [PATCH V8 11/20] qmp: add interface query-images, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 12/20] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 13/20] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 14/20] block: move dump_human_image_info() to block/qapi.c, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 15/20] block: dump to buffer for bdrv_image_info_dump(), Wenchao Xia, 2013/03/07