[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/20] char-socket: fix error reporting
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH 01/20] char-socket: fix error reporting |
Date: |
Tue, 5 Mar 2013 23:21:16 +0530 |
From: Anthony Liguori <address@hidden>
Right now the inet connect code tries all available addresses but until one
doesn't fail. It passes local_err each time without clearing it from the
previous failure. This can trigger an assert since the inet connect code
tries to set an error on an object != NULL.
Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
---
util/qemu-sockets.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 1350ccc..3f12296 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -373,6 +373,10 @@ int inet_connect_opts(QemuOpts *opts, Error **errp,
}
for (e = res; e != NULL; e = e->ai_next) {
+ if (error_is_set(errp)) {
+ error_free(*errp);
+ *errp = NULL;
+ }
if (connect_state != NULL) {
connect_state->current_addr = e;
}
--
1.8.1.2
[Qemu-devel] [PATCH 04/20] qemu-char: convert fd_chr to use a GIOChannel, Amit Shah, 2013/03/05
[Qemu-devel] [PATCH 05/20] qemu-char: convert pty to GIOChannel, Amit Shah, 2013/03/05
[Qemu-devel] [PATCH 06/20] qemu-char: convert UDP to GIOChannel, Amit Shah, 2013/03/05