[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 4/8] add a new runstate: RUN_STATE_GUEST_PAN
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v13 4/8] add a new runstate: RUN_STATE_GUEST_PANICKED |
|
Date: |
Tue, 05 Mar 2013 09:26:18 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 05/03/2013 04:17, Hu Tao ha scritto:
> Will
>
> if (runstate_check(RUN_STATE_INTERNAL_ERROR) ||
> runstate_check(RUN_STATE_SHUTDOWN) ||
> runstate_check(RUN_STATE_GUEST_PANICKED)) {
> runstate_set(RUN_STATE_PAUSED);
> }
>
> be OK? Or I must be misunderstanding you.
>
Please move
return (runstate_check(RUN_STATE_INTERNAL_ERROR) ||
runstate_check(RUN_STATE_SHUTDOWN) ||
runstate_check(RUN_STATE_GUEST_PANICKED));
to a separate function (runstate_needs_reset for example), so that you
can reuse it in the two or three places that need it.
Paolo