[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] block: Add options QDict to bdrv_open_commo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] block: Add options QDict to bdrv_open_common() |
Date: |
Mon, 4 Mar 2013 10:28:42 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Mar 01, 2013 at 09:13:38PM +0100, Kevin Wolf wrote:
> diff --git a/block.c b/block.c
> index bf93dd1..e0e3b99 100644
> --- a/block.c
> +++ b/block.c
> @@ -665,15 +665,18 @@ static int bdrv_open_flags(BlockDriverState *bs, int
> flags)
>
> /*
> * Common part for opening disk images and files
> + *
> + * Removes all processed options from *options.
> */
> static int bdrv_open_common(BlockDriverState *bs, BlockDriverState *file,
> - const char *filename,
> + const char *filename, QDict *options,
The function already has an "options" local variable which will shadow:
/* For snapshot=on, create a temporary qcow2 overlay */
if (flags & BDRV_O_SNAPSHOT) {
BlockDriverState *bs1;
int64_t total_size;
int is_protocol = 0;
BlockDriver *bdrv_qcow2;
QEMUOptionParameter *options;
This could be fixed in a follow-up patch.
Stefan
- [Qemu-devel] [PATCH 0/7] block: Add driver specific options, Kevin Wolf, 2013/03/01
- [Qemu-devel] [PATCH 1/7] block: Add options QDict to .bdrv_open(), Kevin Wolf, 2013/03/01
- [Qemu-devel] [PATCH 2/7] block: Add options QDict to bdrv_open() prototype, Kevin Wolf, 2013/03/01
- [Qemu-devel] [PATCH 3/7] Add qdict_clone_shallow(), Kevin Wolf, 2013/03/01
- [Qemu-devel] [PATCH 4/7] block: Add options QDict to bdrv_open_common(), Kevin Wolf, 2013/03/01
- [Qemu-devel] [PATCH 5/7] qemu-option: Add qemu_opts_absorb_qdict(), Kevin Wolf, 2013/03/01
- [Qemu-devel] [PATCH 6/7] block: Support driver specific options in drive_init(), Kevin Wolf, 2013/03/01
- [Qemu-devel] [PATCH 7/7] qcow2: Allow lazy refcounts to be enabled on the command line, Kevin Wolf, 2013/03/01
- Re: [Qemu-devel] [PATCH 0/7] block: Add driver specific options, Stefan Hajnoczi, 2013/03/04