[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 00/14] add qmp/hmp interfaces for internal sn
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V7 00/14] add qmp/hmp interfaces for internal snapshot info |
Date: |
Thu, 28 Feb 2013 16:57:02 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 26, 2013 at 06:40:14PM +0800, Wenchao Xia wrote:
> This serial of patches does two things: merge some info code
> in qemu-img, and add following interfaces:
> 1) qmp: query-images
> 2) qmp: query-snapshots
> 3) hmp: show internal snapshot info on a single block device
> These patches follows the rule that use qmp to retieve information,
> hmp layer just do a translation from qmp object it got, so almost
> every hmp interface may have a correlated qmp interface.
> To make code graceful, snapshot retrieving code in qemu and qemu-img
> are merged into block.c, and some function name was adjusted to make it
> tips better. Now it works as:
>
> qemu qemu-img
>
> dump_monitor dump_stdout
> |--------------|
> |
> qmp
> |
> block
This summary does not explain how the new commands relate to query-block
or why they are necessary.
It is also useful to include QMP examples or the QMP docs in the cover
letter so reviewers know what you are trying to achieve.
- Re: [Qemu-devel] [PATCH V7 14/14] hmp: show snapshots on single block device, (continued)
[Qemu-devel] [PATCH V7 12/14] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/02/26
[Qemu-devel] [PATCH V7 13/14] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/02/26
[Qemu-devel] [PATCH V7 10/14] block: distinguish id and name in bdrv_find_snapshot(), Wenchao Xia, 2013/02/26
[Qemu-devel] [PATCH V7 11/14] qmp: add interface query-snapshots, Wenchao Xia, 2013/02/26
Re: [Qemu-devel] [PATCH V7 00/14] add qmp/hmp interfaces for internal snapshot info,
Stefan Hajnoczi <=