[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 0/6] kvm: Make ioeventfd usable on s390.
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v5 0/6] kvm: Make ioeventfd usable on s390. |
Date: |
Thu, 28 Feb 2013 15:12:24 +0200 |
On Thu, Feb 28, 2013 at 12:33:15PM +0100, Cornelia Huck wrote:
> v5 of the ioeventfd patch set, this time with a proper return code
> from __diag_virtio_hypercall(), otherwise unchanged.
>
> v4 -> v5:
> - Proper return code in __diag_virtio_hypercall()
> v3 -> v4:
> - Pass cookies in virtio-ccw notify hypercall
> - Coding style
> v2 -> v3:
> - Added a patch exporting the virtio-ccw api and use it for the
> diagnose implementation.
> - Better naming: We're dealing with virtio-ccw notifications only.
> v1 -> v2:
> - Move irqfd initialization from a module init function to kvm_init,
> eliminating the need for a second module for kvm/s390.
> - Use kvm_io_device for s390 css devices.
The patches look obviously correct to me.
I take no strong position on whether the userspace interface
and the addition of virtio-specific bits in s390 kvm are
acceptable, but looks ok to me too.
Acked-by: Michael S. Tsirkin <address@hidden>
> Cornelia Huck (5):
> KVM: s390: Export virtio-ccw api.
> KVM: Initialize irqfd from kvm_init().
> KVM: Introduce KVM_VIRTIO_CCW_NOTIFY_BUS.
> KVM: ioeventfd for virtio-ccw devices.
> KVM: s390: Wire up ioeventfd.
>
> Michael S. Tsirkin (1):
> virtio_ccw: pass a cookie value to kvm hypercall
>
> Documentation/virtual/kvm/api.txt | 8 ++++++++
> arch/s390/include/uapi/asm/Kbuild | 1 +
> arch/s390/include/uapi/asm/virtio-ccw.h | 21 +++++++++++++++++++++
> arch/s390/kvm/Kconfig | 1 +
> arch/s390/kvm/Makefile | 2 +-
> arch/s390/kvm/diag.c | 26 ++++++++++++++++++++++++++
> arch/s390/kvm/kvm-s390.c | 1 +
> drivers/s390/kvm/virtio_ccw.c | 16 +++++++++-------
> include/linux/kvm_host.h | 14 ++++++++++++++
> include/uapi/linux/kvm.h | 3 +++
> virt/kvm/eventfd.c | 24 +++++++++++++++---------
> virt/kvm/kvm_main.c | 6 ++++++
> 12 files changed, 106 insertions(+), 17 deletions(-)
> create mode 100644 arch/s390/include/uapi/asm/virtio-ccw.h
>
> --
> 1.7.12.4
- [Qemu-devel] [PATCH v5 0/6] kvm: Make ioeventfd usable on s390., Cornelia Huck, 2013/02/28
- [Qemu-devel] [PATCH v5 2/6] KVM: s390: Export virtio-ccw api., Cornelia Huck, 2013/02/28
- [Qemu-devel] [PATCH v5 3/6] KVM: Initialize irqfd from kvm_init()., Cornelia Huck, 2013/02/28
- [Qemu-devel] [PATCH v5 1/6] virtio_ccw: pass a cookie value to kvm hypercall, Cornelia Huck, 2013/02/28
- [Qemu-devel] [PATCH v5 6/6] KVM: s390: Wire up ioeventfd., Cornelia Huck, 2013/02/28
- [Qemu-devel] [PATCH v5 4/6] KVM: Introduce KVM_VIRTIO_CCW_NOTIFY_BUS., Cornelia Huck, 2013/02/28
- [Qemu-devel] [PATCH v5 5/6] KVM: ioeventfd for virtio-ccw devices., Cornelia Huck, 2013/02/28
- Re: [Qemu-devel] [PATCH v5 0/6] kvm: Make ioeventfd usable on s390.,
Michael S. Tsirkin <=