|
From: | Gal Hammer |
Subject: | Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device? |
Date: | Wed, 27 Feb 2013 15:24:12 +0200 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 |
On 27/02/2013 14:35, Amit Shah wrote:
On (Mon) 04 Feb 2013 [11:59:02], Michael S. Tsirkin wrote:On Mon, Feb 04, 2013 at 10:42:32AM +0100, Paolo Bonzini wrote:Il 03/02/2013 13:11, Michael S. Tsirkin ha scritto:static Property virtio_serial_properties[] = { DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true), - DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, DEV_NVECTORS_UNSPECIFIED), + DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2), DEFINE_PROP_HEX32("class", VirtIOPCIProxy, class_code, 0), DEFINE_VIRTIO_COMMON_FEATURES(VirtIOPCIProxy, host_features), DEFINE_PROP_UINT32("max_ports", VirtIOPCIProxy, serial.max_virtserial_ports, 31), plus the backwards-compatibility stuff. PaoloMakes sense, but the logic in virtio_serial_init_pci is then dead code and should go away.It won't be dead code for the backwards-compatible machine types (that use DEV_NVECTORS_UNSPECIFIED). PaoloGood point. Ack. Want to post this with proper signature etc?Gal, do you want to submit a patch for this? Amit
Attached. Gal.
0001-Set-virtio-serial-device-to-have-a-default-of-2-MSI-.patch
Description: Text document
[Prev in Thread] | Current Thread | [Next in Thread] |