qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 4/6] introduce new vma archive format


From: Dietmar Maurer
Subject: Re: [Qemu-devel] [PATCH v5 4/6] introduce new vma archive format
Date: Mon, 25 Feb 2013 06:18:54 +0000

> > +    if (full_read(vmar->fd, vmar->head_data, sizeof(VmaHeader)) !=
> > +        sizeof(VmaHeader)) {
> > +        error_setg(errp, "can't read vma header - %s",
> > +                   errno ? strerror(errno) : "got EOF");
> 
> You're not the first user, but strerror() isn't thread-safe.  strerror_r is 
> not
> necessarily portable (glibc vs. POSIX), and strerror_l isn't yet widely
> implemented.  Should qemu be providing a better interface
> qemu_strerror() that guarantees thread-safety when converting errno to a
> string?

I thought I can use g_strerror?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]