Re: [Qemu-devel] [PATCH 35/41] migration: use QEMUFile for writing outgoing migration data

[Juan Quintela]

Paolo Bonzini <address@hidden> wrote:
> Second, drop the file descriptor indirection, and write directly to the
> QEMUFile.
>
> Signed-off-by: Paolo Bonzini <address@hidden>

> +    qemu_put_buffer(s->migration_file, buf, size);
> +    if (qemu_file_get_error(s->migration_file)) {
> +        return qemu_file_get_error(s->migration_file);

Rest of patch is really, really nice.

But here, please, use a local variable.

    qemu_put_buffer(s->migration_file, buf, size);
    ret = qemu_file_get_error(s->migration_file);
    if (ret) {
       return ret;
    }