Re: [Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

[Paolo Bonzini]

Il 21/02/2013 13:52, Andreas Färber ha scritto:
> As discussed on IRC, what happened here it seems is that at the time of
> writing the patch (two releases ago) we had -include *.d in
> Makefile.target, so the generated .mak.d files were effectively included
> from two Makefiles, working for one but not for the other. So
> effectively we were observing race conditions between Makefile and
> x86_64-softmmu/Makefile a.k.a. Makefile.target.
> This seems to have gotten fixed through Paolo's nested-vars handling in
> rules.mak, which only does -include *.d for directories listed in obj-y
> etc. So my patch was broken and is now completely broken. :(
> 
> However I don't see in the curent Makefile.target and rules.mak where
> the *.d files are being included today

Makefile.target also includes Makefile.objs and calls the unnesting
machinery in rules.mak.  The machinery then includes the .d files.

Paolo

> , so we may have discovered a
> different issue that if fixed may reintroduce the original bug again...