qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] piix_pci: Use ISA_BUS() instead of DO_UPCAS


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 2/4] piix_pci: Use ISA_BUS() instead of DO_UPCAST()
Date: Thu, 21 Feb 2013 00:08:26 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2

Am 20.02.2013 22:46, schrieb David Woodhouse:
> From: David Woodhouse <address@hidden>
> 
> Signed-off-by: David Woodhouse <address@hidden>
> ---
>  hw/piix_pci.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 6b69e26..d45449a 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -301,8 +301,7 @@ static PCIBus *i440fx_common_init(const char *device_name,
>          pci_bus_set_route_irq_fn(b, piix3_route_intx_pin_to_irq);
>      }
>      piix3->pic = pic;
> -    *isa_bus = DO_UPCAST(ISABus, qbus,
> -                         qdev_get_child_bus(&piix3->dev.qdev, "isa.0"));
> +    *isa_bus = ISA_BUS(qdev_get_child_bus(&piix3->dev.qdev, "isa.0"));
>  
>      *piix3_devfn = piix3->dev.devfn;
>  

Use of ISA_BUS() is correct, but it would be nice to use (DEVICE(piix3),
...) if respun.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]