Re: [Qemu-devel] [PATCH V24 1/7] Support for TPM command line options

[Corey Bryant]

On 02/19/2013 04:59 PM, Stefan Berger wrote:
> On 02/19/2013 04:42 PM, Corey Bryant wrote:
> > > diff --git a/tpm/Makefile.objs b/tpm/Makefile.objs
> > > new file mode 100644
> > > index 0000000..dffb567
> > > --- /dev/null
> > > +++ b/tpm/Makefile.objs
> > > @@ -0,0 +1 @@
> > > +common-obj-y = tpm.o
> > > diff --git a/tpm/tpm.c b/tpm/tpm.c
> > > new file mode 100644
> > > index 0000000..51eaf7e
> > > --- /dev/null
> > > +++ b/tpm/tpm.c
> > > @@ -0,0 +1,345 @@
> > > +/*
> > > + * TPM configuration
> > > + *
> > > + * Copyright (C) 2011-2013 IBM Corporation
> > > + *
> > > + * Authors:
> > > + *  Stefan Berger    <address@hidden>
> > > + *
> > > + * This work is licensed under the terms of the GNU GPL, version 2
> > > or later.
> > > + * See the COPYING file in the top-level directory.
> > > + *
> > > + * Based on net.c
> > > + */
> > > +#include "config-host.h"
> > > +
> > > +#include "monitor/monitor.h"
> > > +#include "qapi/qmp/qerror.h"
> > > +#include "tpm_int.h"
> > > +#include "tpm/tpm.h"
> > > +#include "qemu/config-file.h"
> > > +#include "qmp-commands.h"
> > > +
> > > +static QLIST_HEAD(, TPMBackend) tpm_backends =
> > > +    QLIST_HEAD_INITIALIZER(tpm_backends);
> > > +
> > > +
> > > +#define TPM_MAX_MODELS      1
> > > +#define TPM_MAX_DRIVERS     2
> >
> > Should TPM_MAX_DRIVERS be 1?
>
> It leaves us room for 1 more already -- libtpms driver.

Yeah I figured that would get bumped to 2 when the software vTPM patches 
come out.

--
Regards,
Corey Bryant