Re: [Qemu-devel] [PATCH] i440fx: implement reset

[Andreas Färber]

Am 20.02.2013 18:24, schrieb David Woodhouse:
> On Wed, 2013-02-20 at 17:17 +0100, Andreas Färber wrote:
>>> +static void i440fx_reset(DeviceState *ds)
>>> +{
>>> +    PCIDevice *dev = DO_UPCAST(PCIDevice, qdev, ds);
>>> +    PCII440FXState *d = DO_UPCAST(PCII440FXState, dev, dev);
>>
>> Please don't use DO_UPCAST() on QOM objects, there's QOM cast macros for
>> this, like PCI_DEVICE(). If there's one missing for PCII440FXState (I
>> think I only added them for the PHB itself?), it's two lines to add.
> 
> Would you care to elaborate on exactly what those two lines would look
> like? Being *completely* unfamiliar with qemu code, it took me long
> enough to work out the DO_UPCAST version.

static void i440fx_reset(DeviceState *dev)
{
    PCIDevice *pci = PCI_DEVICE(dev);
    PCII440FXState *d = I440FX_PCI_WHATEVER_CAST_MACRO_NAME(dev);

HTH,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg