[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND for 1.4-stable] net: reduce memory alloca
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH RESEND for 1.4-stable] net: reduce memory allocation when multiqueue is not used |
Date: |
Wed, 20 Feb 2013 14:01:22 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 20, 2013 at 06:11:33PM +0800, Jason Wang wrote:
> Edivaldo reports a problem that the array of NetClientState in NICState is too
> large - MAX_QUEUE_NUM(1024) which will waste memory even if multiqueue is not
> used.
>
> For 1.4 we can just solve this by reduce the MAX_QUEUE_NUM to 8 which is the
> same as the current kernel (3.8+) tap queue limit. For 1.5, we will use
> dynamic
> allocation instead.
>
> Cc: Edivaldo de Araujo Pereira <address@hidden>
> Signed-off-by: Jason Wang <address@hidden>
> ---
> RESEND since the previous mail misses the list.
> ---
> include/net/net.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Is dynamic allocation much more complex? If it takes another 2 or 3
days to come up with a patch, then that would be preferrable to a static
8 queue limit.
Stefan