Re: [Qemu-devel] [PATCH v10 2/3] pl330: Initial version

[Peter Crosthwaite]

On Wed, Feb 20, 2013 at 4:02 AM, Igor Mitsyanko <address@hidden> wrote:
>
> On 02/19/2013 09:53 PM, Peter Maydell wrote:
>>
>> On 19 February 2013 17:44, Igor Mitsyanko <address@hidden> wrote:
>>>
>>> On 02/19/2013 11:46 AM, Peter Crosthwaite wrote:
>>>>
>>>> Device model for Primecell PL330 DMA controller.
>>>>
>>>> Signed-off-by: Peter Crosthwaite <address@hidden>
>>>> Signed-off-by: Kirill Batuzov <address@hidden>
>>>> Tested-by: Igor Mitsyanko <address@hidden>
>>>
>>>
>>> Is my reviewed-by required if it already has my tested-by? I have a few
>>> minor comments bellow and then you can add my reviewed-by tag if you
>>> want.
>>
>> They mean different things (both worth noting):
>> Tested-by means you ran the code and it did the right thing
>> Reviewed-by means you read the code and it looks good
>
>
> I thought reviewed-by implied tested-by) I'll add this tag to a next patch
> version then.
>

I got told off on LKML for adding both a reviewed by and tested by tag
for the one patch. My understanding was tested-by trumps reviewed by,
but they are completely different things IMO so should be able to add
both.

Regards,
Peter

>>
>> -- PMM
>>
>
> --
> Mitsyanko Igor
> ASWG, Moscow R&D center, Samsung Electronics
> email: address@hidden
>
>