[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V6 03/14] block: return bool for bdrv_can_snapsh
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V6 03/14] block: return bool for bdrv_can_snapshot() |
Date: |
Tue, 19 Feb 2013 13:48:55 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/18/2013 07:09 AM, Wenchao Xia wrote:
> This function should return bool instead of int, just as
> bdrv_can_read_snapshot().
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block.c | 8 ++++----
> include/block/block.h | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
I checked that all existing callers only used the function in a boolean
context.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V6 00/14] add qmp/hmp interfaces for internal snapshot info, Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 01/14] qemu-img: remove unused parameter in collect_image_info(), Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 02/14] block: add bdrv_can_read_snapshot() function, Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 03/14] block: return bool for bdrv_can_snapshot(), Wenchao Xia, 2013/02/18
- Re: [Qemu-devel] [PATCH V6 03/14] block: return bool for bdrv_can_snapshot(),
Eric Blake <=
- [Qemu-devel] [PATCH V6 07/14] block: rename bdrv_query_info() to bdrv_query_block_info(), Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 06/14] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 04/14] block: move collect_snapshots() and collect_image_info() to block.c, Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 12/14] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/02/18
- [Qemu-devel] [PATCH V6 09/14] block: move bdrv_snapshot_find() to block.c, Wenchao Xia, 2013/02/18