[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] Improve grlib-apbuart
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] Improve grlib-apbuart |
Date: |
Tue, 19 Feb 2013 14:26:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 19.02.2013 12:45, schrieb Fabien Chouteau:
> From: Ronald Hecht <address@hidden>
>
> From: Ronald Hecht <address@hidden>
>
> Signed-off-by: Fabien Chouteau <address@hidden>
Duplicate From header and no proper commit message.
The patch is doing too many things at once: Renaming gptimer ->apbuart
should go into its own patch for instance and not be mixed with adding
reset support and whatever functional UART changes.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg