Re: [Qemu-devel] [PATCH] Fix conversion between 12 hours and 24 hours modes.

[Andreas Färber]

Am 14.02.2013 12:11, schrieb Peter Maydell:
> On 14 December 2012 22:53, Antoine Mathys <address@hidden> wrote:
>> The proper mapping between 24 hours and 12 hours modes is:
>> 0       12 AM
>> 1-11    1-11 AM
>> 12      12 PM
>> 13-23   1-11 PM
>> Fix code accordingly.
>>
>> Signed-off-by: Antoine Mathys <address@hidden>
> 
> Sorry, I missed this patch earlier.
> Reviewed-by: Peter Maydell <address@hidden>
> 
> (and I've had confirmation from somebody that this change
> makes us match the hardware behaviour where AM/PM is
> toggled when we go from 11:59 to 12:00).
> 
> I tweaked the commit message a little (added hw/ds1338:
> prefix to the summary and removed the hardcoded tabs)
> and have queued it in arm-devs.next.

I may be repeating myself here, but adding qtests as requested would've
caught this. And they should even more be added to avoid regressions.
There's even templates to copy for RTC, and the new Big Endian-safe
{read,write}[bwlq]() functions for 1.5 are on the list and got a
Reviewed-by from Anthony in the unpolished version, so only
implementation details might still change.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg