Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

[Gerd Hoffmann]

  Hi,

> But why nested discriminators?
> 
>     regular files: type=file
>     serial       : type=port, data.type=serial
>     parallel     : type=port, data.type=parallel
> 
> Simpler, and closer to existing -chardev:
> 
>     regular files: type=file
>     serial       : type=serial
>     parallel     : type=parallel

Matter of taste IMHO.
I can live with that too.
Feel free to send patches.

> I also dislike the pointless '"data" : {}' required by type pty and
> null, but I can't figure out how to express 'void' in the schema.

Someone mentioned it is possible to leave out empty data altogether.
Didn't try whenever our marshaller actually accepts that though.

cheers,
  Gerd