[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4 0/2] block-migration: fix pending() and
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH for-1.4 0/2] block-migration: fix pending() and iterate() return values |
Date: |
Tue, 12 Feb 2013 12:47:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 12/02/2013 10:37, Stefan Hajnoczi ha scritto:
> This series finally ensures that we never complete block migration before the
> entire disk image has been transferred.
>
> Juan explained to me on IRC yesterday what the .save_live_pending() and
> .save_live_iterate() are supposed to return. I had misunderstood them when
> reading outdated code in savevm.c and 2c5a7f20112615ce13a3434ab90bee1ed8d44ebd
> does not prevent block migration from completing too early.
>
> See the patch descriptions for an explanation of what the .save_live_pending()
> and .save_live_iterate() return values mean.
>
> Stefan Hajnoczi (2):
> migration: make qemu_ftell() public and support writable files
> block-migration: fix pending() and iterate() return values
>
> block-migration.c | 22 +++++++++++++---------
> include/migration/qemu-file.h | 1 +
> savevm.c | 9 +++++++--
> 3 files changed, 21 insertions(+), 11 deletions(-)
>
Looks good, thanks!
Paolo