|
From: | Corey Bryant |
Subject: | Re: [Qemu-devel] [PATCH V21 2/7] Add TPM (frontend) hardware interface (TPM TIS) to QEMU |
Date: | Mon, 11 Feb 2013 13:49:16 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/11/2013 01:35 PM, Stefan Berger wrote:
On 02/11/2013 12:53 PM, Corey Bryant wrote:On 02/08/2013 04:42 PM, Stefan Berger wrote:The TPM TIS driver's backend was previously chosen in the code added to arch_init. The frontend holds a pointer to the chosen backend (interface). Communication with the backend is based on thread pools.I'm not sure this sentence above makes sense since the thread pools are just a threading mechanism, not a communication mechanism. Maybe you want to drop the sentence if you have to submit a new version.let me clarify : ... is based on submitting tasks to thread pools. Better?
Doesn't the backend submit tasks to the host TPM from the thread pools?
+ + s->be_driver->fe_model = TPM_MODEL_TPM_TIS;Where is TPM_MODEL_TPM_TIS defined?It's auto-generated from the qapi-schema.json.
Ah, I thought maybe that was it after I commented. -- Regards, Corey Bryant
[Prev in Thread] | Current Thread | [Next in Thread] |