Re: [Qemu-devel] [PATCH] m25p80.c: Use QOM classes for part differentiation

[Andreas Färber]

Am 07.02.2013 06:51, schrieb Peter Crosthwaite:
> Currently, M25P80 uses an object property to differentiate between flash 
> parts.
> Changed this over to use QOM sub-classes - the actual names of the different 
> parts
> are used to create a set of dynamic classes which passes the part info as 
> class
> data. The object no longer needs to search the known_devices table for itself,
> instead it just gets its info from its own class.
> 
> Kept the intermediate class definition private to m25p80.c for the moment, as
> the expectation is parts will only be added as new entries in the table. We 
> can
> factor out the TYPE_M25P80 abstraction into a header on a demand basis.
> 
> Signed-off-by: Peter Crosthwaite <address@hidden>

Reviewed-by: Andreas Färber <address@hidden>

Looks fine to me except that I would suggest to #define a TYPE_N25Q128
constant. No typos though, so that can be done later.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg