[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-1.4? v2 3/5] tmp105-test: Combine assertions of
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PATCH for-1.4? v2 3/5] tmp105-test: Combine assertions of 16-bit responses |
Date: |
Wed, 6 Feb 2013 19:33:28 +0100 |
From: Andreas Färber <address@hidden>
Instead of comparing bytes individually, compare the full values.
This aids spotting endianness issues.
Signed-off-by: Andreas Färber <address@hidden>
---
tests/tmp105-test.c | 8 ++++----
1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-)
diff --git a/tests/tmp105-test.c b/tests/tmp105-test.c
index a6ad213..a1fe99e 100644
--- a/tests/tmp105-test.c
+++ b/tests/tmp105-test.c
@@ -40,16 +40,16 @@ static void send_and_receive(void)
cmd[2] = 0x34;
i2c_send(i2c, addr, cmd, 3);
i2c_recv(i2c, addr, resp, 2);
- g_assert_cmphex(resp[0], ==, cmd[1]);
- g_assert_cmphex(resp[1], ==, cmd[2]);
+ g_assert_cmphex(((uint16_t)resp[0] << 8) | resp[1], ==,
+ ((uint16_t)cmd[1] << 8) | cmd[2]);
cmd[0] = TMP105_REG_T_HIGH;
cmd[1] = 0x42;
cmd[2] = 0x31;
i2c_send(i2c, addr, cmd, 3);
i2c_recv(i2c, addr, resp, 2);
- g_assert_cmphex(resp[0], ==, cmd[1]);
- g_assert_cmphex(resp[1], ==, cmd[2]);
+ g_assert_cmphex(((uint16_t)resp[0] << 8) | resp[1], ==,
+ ((uint16_t)cmd[1] << 8) | cmd[2]);
}
int main(int argc, char **argv)
--
1.7.10.4
- [Qemu-devel] [PATCH RFC v2 0/5] qtest: tmp105-test BE fix for 1.4 and MMIO support, Andreas Färber, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 1/5] qtest: Use strtoull() for uint64_t, Andreas Färber, 2013/02/06
- [Qemu-devel] [PATCH for-1.4? v2 3/5] tmp105-test: Combine assertions of 16-bit responses,
Andreas Färber <=
- [Qemu-devel] [RFC v2 5/5] qtest: Add MMIO support, Andreas Färber, 2013/02/06
- [Qemu-devel] [PATCH for-1.4 v2 2/5] libi2c-omap: Fix endianness dependency, Andreas Färber, 2013/02/06
- [Qemu-devel] [PATCH v2 4/5] tmp105: Add debug output, Andreas Färber, 2013/02/06
- Re: [Qemu-devel] [PATCH RFC v2 0/5] qtest: tmp105-test BE fix for 1.4 and MMIO support, Anthony Liguori, 2013/02/12