[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/5] qcow2: add fragmentation and compression
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/5] qcow2: add fragmentation and compression info support |
Date: |
Wed, 06 Feb 2013 06:37:19 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/06/2013 03:58 AM, Stefan Hajnoczi wrote:
> This series adds fragmentation info support to qcow2 and then adds compression
> info. Previously only QED supported fragmentation info. Note that
> fragmentation info only covers the current image, internal snapshots are not
> included.
>
> The new BlockFragInfo.compressed field contains the number of compressed
> clusters. qemu-img check now reports the percentage of compressed clusters
> out
> of all allocated clusters. This can be used to decide when to recompress an
> image or to double-check that an image is indeed compressed.
>
> qemu-iotests was to handle the new qemu-img check output.
>
> I have tested qcow2 images both compressed and uncompressed.
>
> v2:
> * Fix indentation on modified block/qcow2-refcount.c lines [eblake]
> * Change qemu-img check output from just "compressed" to "compressed
> clusters" [eblake]
> * Improve grep and sed usage in common.rc [eblake]
> * Introduce sector_offset local variable for & ~511 [eblake]
> * Improve nb_csectors rounding down explanation in comment [eblake]
Thanks; from my point of view, series:
Reviewed-by: Eric Blake <address@hidden>
Up to you and Kevin what to do about his comment on patch 3; while
changing the output might break users that scrape output, we are already
changing the output to display more information than previously, so I
can live with either approach (adding the space or leaving existing
formatting).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 1/5] qcow2: introduce check_refcounts_l1/l2() flags, (continued)
[Qemu-devel] [PATCH v2 4/5] qemu-img: add compressed clusters to BlockFragInfo, Stefan Hajnoczi, 2013/02/06
[Qemu-devel] [PATCH v2 5/5] qcow2: support compressed clusters in BlockFragInfo, Stefan Hajnoczi, 2013/02/06
Re: [Qemu-devel] [PATCH v2 0/5] qcow2: add fragmentation and compression info support,
Eric Blake <=