[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] Fix misuse of atomics in trace/simple.c
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] Fix misuse of atomics in trace/simple.c |
Date: |
Wed, 06 Feb 2013 08:16:34 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Stefan Hajnoczi <address@hidden> writes:
> On Fri, Jan 25, 2013 at 04:43:36PM +0100, Markus Armbruster wrote:
>> More old news: casting pointers considered harmful, and atomics
>> considered hard to use correctly.
>>
>> Markus Armbruster (4):
>> trace: Fix simple trace dropped event record for big endian
>> trace: Direct access of atomics is verboten, use the API
>> trace: Clean up the "try to update atomic until it worked" loops
>> trace: Fix location of simpletrace.py in docs
>>
>> docs/tracing.txt | 4 ++--
>> trace/simple.c | 39 ++++++++++++++++-----------------------
>> 2 files changed, 18 insertions(+), 25 deletions(-)
>>
>> --
>> 1.7.11.7
>>
>>
>
> First patch is a little controversial but still a net improvement. Too
> bad uint64_t dropped_events is reduced to int but its usage really was
> dodgy.
We don't really lose range, because only its int-sized part was used.
> Thanks, applied to the trivial patches tree:
> https://github.com/stefanha/qemu/commits/trivial-patches
Thanks!