[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] fix qemu_flush_queued_packets() in presence
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] fix qemu_flush_queued_packets() in presence of a hub |
|
Date: |
Tue, 5 Feb 2013 16:55:06 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 05, 2013 at 03:46:19PM +0100, Luigi Rizzo wrote:
> On Tue, Jan 29, 2013 at 02:08:27PM +0100, Stefan Hajnoczi wrote:
>
> > It's cleaner to add a bool (*flush)(NetClientState *nc) function to
> > NetClientInfo but given that net.c already knows about hub.c
> > specifically we don't gain much by trying to decouple this callback. If
> > you want to leave it hardcoded that's fine by me.
>
> I'd leave it like this for now. Here is the version with fixed style bugs.
Great, please send the patch as a new email thread. That way patch
tracking scripts will detect it and it's easier for maintainers to spot
the patch as well.
Stefan