Re: [Qemu-devel] [PATCH for-1.4] libqtest: Wait for the right child PID after killing QEMU

[Andreas Färber]

Am 30.01.2013 03:14, schrieb Anthony Liguori:
> Andreas Färber <address@hidden> writes:
> 
>> Am 28.01.2013 19:15, schrieb Eduardo Habkost:
>>> When running "make check" with gcov enabled, we get the following
>>> message:
>>>
>>>    hw/tmp105.gcda:cannot open data file, assuming not executed
>>>
>>> The problem happens because:
>>>
>>>  * tmp105-test exits before QEMU exits, because waitpid() at
>>>    qtest_quit() fails;
>>>  * waitpid() fails because there's another process already
>>>    waiting for the QEMU process;
>>>  * The process that is already waiting for QEMU is the child created by
>>>    qtest_init() to run system();
>>>  * qtest_quit() is incorrectly waiting for the QEMU PID directly instead
>>>    of the child created by qtest_init().
>>>
>>> This fixes the problem by sending SIGTERM to QEMU, but waiting for the
>>> child process created by qtest_init() (that exits immediately after QEMU
>>> exits).
>>>
>>> Reported-by: Andreas Färber <address@hidden>
>>> Signed-off-by: Eduardo Habkost <address@hidden>
>>
>> Thanks. Still need to test this...
>>
>> Anthony, might this by any chance fix your sparc 100% CPU issue?
> 
> I don't see how.  How would this impact the QEMU process?

I had previously reported failing tests leading to the QEMU process not
being killed and eating CPU and memory until the system becomes very
unresponsive. Possibly that's a second issue because as I understand it
an assertion in the test program makes it exit immediately without any
cleanup.

Regards,

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg