[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4?] target-i386: Pass X86CPU to cpu_x86_se
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.4?] target-i386: Pass X86CPU to cpu_x86_set_a20() |
|
Date: |
Thu, 31 Jan 2013 17:11:38 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 31.01.2013 16:49, schrieb Eduardo Habkost:
> On Thu, Jan 31, 2013 at 04:08:44PM +0100, Andreas Färber wrote:
>> Prepares for cpu_interrupt() changing argument to CPUState.
>>
>> While touching it, rename to x86_cpu_...() now that it takes an X86CPU.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>
> Reviewed-by: Eduardo Habkost <address@hidden>
>
> Why the "for-1.4?"?
I'm suggesting it for 1.4 as a non-intrusive cleanup, for Igor and you
to rebase property etc. work on to avoid merge conflicts (being my sole
such i386-only patch currently). If there are any concerns, I can put it
into qom-cpu-next instead (where the cpu_init changes are queued).
> Is there a for-1.4 bug fix that depends on this?
No, it is not strictly needed, I'm just flushing my queue of preparatory
patches to get my upcoming qom-cpu-8 patchset shorter - I probably need
to split off a qom-cpu-9 though.
Andreas
>> ---
>> Extracted from my qom-cpu-8 queue.
[snip]
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg