[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V17 04/10] libqblock: build: add rule for libqbl
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V17 04/10] libqblock: build: add rule for libqblock.la |
Date: |
Thu, 31 Jan 2013 15:36:51 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 31, 2013 at 04:53:44PM +0800, Wenchao Xia wrote:
> diff --git a/libqblock/Makefile b/libqblock/Makefile
> index 8173da7..a6be721 100644
> --- a/libqblock/Makefile
> +++ b/libqblock/Makefile
> @@ -1,4 +1,29 @@
> all: libqblock.la
>
> -libqblock.la:
> - @true
> +# objects linked into a shared library, built with libtool with -fPIC if
> required
> +libqblock-obj-y = libqblock/libqblock.o libqblock/libqblock-error.o
> +libqblock-obj-y += $(filter-out stubs/set-fd-handler.o, $(stub-obj-y))
I guess you will reimplement the function yourself later? Please
include a comment explaining the reason for making this exception.
- [Qemu-devel] [PATCH V17 00/10] libqblock qemu block layer library, Wenchao Xia, 2013/01/31
- [Qemu-devel] [PATCH V17 01/10] build: add command check-clean, Wenchao Xia, 2013/01/31
- [Qemu-devel] [PATCH V17 04/10] libqblock: build: add rule for libqblock.la, Wenchao Xia, 2013/01/31
- Re: [Qemu-devel] [PATCH V17 04/10] libqblock: build: add rule for libqblock.la,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH V17 05/10] libqblock: build: add packaging support, Wenchao Xia, 2013/01/31
- [Qemu-devel] [PATCH V17 06/10] block: export function path_has_protocol(), Wenchao Xia, 2013/01/31
- [Qemu-devel] [PATCH V17 02/10] build: hide symbols in *.lo, Wenchao Xia, 2013/01/31
- [Qemu-devel] [PATCH V17 03/10] libqblock: build: add configure support, Wenchao Xia, 2013/01/31
- [Qemu-devel] [PATCH V17 09/10] libqblock: build: add rules for test case, Wenchao Xia, 2013/01/31
- [Qemu-devel] [PATCH V17 07/10] libqblock: libqblock API design and type defines, Wenchao Xia, 2013/01/31