Re: [Qemu-devel] [PATCH] bswap: Don't rely on HOST_LONG_BITS

[Richard Henderson]

On 01/30/2013 01:56 PM, Stefan Weil wrote:
> Could you please try whether this patch fixes the build problems:
>
>
>  From 4dd39af7a3e493669977ec6f50e91bf649b5727f Mon Sep 17 00:00:00 2001
> From: Stefan Weil <address@hidden>
> Date: Wed, 30 Jan 2013 22:52:12 +0100
> Subject: [PATCH] Fix build problems for big endian hosts
>
> Make sure that HOST_LONG_BITS is always defined when qemu/bswap.h
> is included.
>
> Signed-off-by: Stefan Weil <address@hidden>

This probably works.  And from the list of includes removed, looks good 
from a long-term maintenance point of view.

I stand by my use of ULONG_MAX to match the unsigned long type though.


r~