qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variab

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables
Date: Tue, 29 Jan 2013 07:32:48 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12 
  Hi,

>  hw/usb/hcd-ehci-sysbus.c |    6 ++++++
>  hw/usb/hcd-ehci.c        |   21 +++++++++++++--------
>  hw/usb/hcd-ehci.h        |   12 ++++++------

> +    s->portscbase = sec->portscbase;
> +    s->portnr = sec->portnr;

These two must be initialized in usb_ehci_pci_initfn too.

Otherwise the patch looks fine.

cheers,
  Gerd
reply via email to
[Prev in Thread] Current Thread [Next in Thread]