Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

[Kuo-Jung Su]

Hi Gerd:

Thanks for reminding me of the usb_ehci_pci_initfn.

But I have a stupid question.......

Which one do the upcoming path v2 looks like ?

1. It contains only the diff to usb_ehci_pci_initfn, for example:

    [Qemu-devel][PATCH v2 0/1] usb-ehci: add Faraday FUSBH200 support
    [Qemu-devel][PATCH v2 1/1] usb-ehci: update usb_ehci_pci_initfn to use variable version of portsc

2. It contains the entired change logs, for example:

    [Qemu-devel][PATCH v2 0/3] usb-ehci: add Faraday FUSBH200 support
    [Qemu-devel][PATCH v2 1/3] usb-ehci: replace PORTSC macros with variables ..
    [Qemu-devel][PATCH v2 2/3] usb-ehci: add Faraday FUSBH200 support
    [Qemu-devel][PATCH v2 3/3] usb-ehci: update usb_ehci_pci_initfn ...

I know this is stupid, but I really need the answer.

Thanks you!

Best Wishes

Dante Su

2013/1/29 Gerd Hoffmann <address@hidden>

  Hi,

>  hw/usb/hcd-ehci-sysbus.c |    6 ++++++
>  hw/usb/hcd-ehci.c        |   21 +++++++++++++--------
>  hw/usb/hcd-ehci.h        |   12 ++++++------

> +    s->portscbase = sec->portscbase;
> +    s->portnr = sec->portnr;

These two must be initialized in usb_ehci_pci_initfn too.

Otherwise the patch looks fine.

cheers,
  Gerd

--
Best wishes,
Kuo-Jung Su