[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv4 2/2] qemu-img: add json output option to the c
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCHv4 2/2] qemu-img: add json output option to the check command |
|
Date: |
Mon, 28 Jan 2013 11:02:57 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 01/28/2013 04:59 AM, Federico Simoncelli wrote:
> This option --output=[human|json] makes qemu-img check output a human
> or JSON representation at the choice of the user.
>
> Signed-off-by: Federico Simoncelli <address@hidden>
> ---
> qapi-schema.json | 46 +++++++++++
> qemu-img-cmds.hx | 4 +-
> qemu-img.c | 232
> +++++++++++++++++++++++++++++++++++++++---------------
> qemu-img.texi | 5 +-
> 4 files changed, 220 insertions(+), 67 deletions(-)
In my earlier review, I suggested splitting this into two patches:
https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg03858.html
But I guess Kevin was okay with it as one patch. Therefore:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature